serge/site-mva-global-fret
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore(post-cutover): fix 3 polish bugs (welcome-back, mobile lang switcher, animate-on-scroll) #6

Merged
serge merged 1 commits from chore/post-cutover-polish into main 2026-05-07 16:36:29 +03:00
Conversation 0 Commits 1 Files Changed 11 +5 -52
serge commented 2026-05-07 16:36:26 +03:00
Owner
Copy Link

Three small fixes reported during E2E retest 2026-05-07:

  1. Disable EmailJS welcome-back (Melissa-only, footer 2025)
  2. Remove duplicate .lang-switcher from .mobile-nav (10 HTML files)
  3. animate-on-scroll IntersectionObserver threshold 0.1 ? 0 (fixes invisible content on mobile cgv + politique-confidentialite)

Refs: post-cutover polish.

Three small fixes reported during E2E retest 2026-05-07: 1. Disable EmailJS welcome-back (Melissa-only, footer 2025) 2. Remove duplicate .lang-switcher from .mobile-nav (10 HTML files) 3. animate-on-scroll IntersectionObserver threshold 0.1 ? 0 (fixes invisible content on mobile cgv + politique-confidentialite) Refs: post-cutover polish.
serge added 1 commit 2026-05-07 16:36:26 +03:00 
Three small post-cutover fixes reported during E2E retest 2026-05-07:

1. js/form-handler.js: disable EmailJS welcome-back call in
   showAlreadyRegistered. The EmailJS account is Melissa-only
   (no Serge access) and its template still has a '(c) 2025' footer
   inconsistent with the Resend emails sent by the new Worker.
   The user already sees their existing reference number in the
   showAlreadyRegistered modal (= cosmetic email, not critical).
   To re-implement properly: route through Worker + Resend in a
   future PR.

2. 10 HTML pages: remove duplicate .lang-switcher block from
   .mobile-nav. The header already has a lang-switcher visible on
   mobile, the second one inside the slide-in mobile menu was redundant.

3. js/main.js: fix IntersectionObserver threshold for animate-on-scroll.
   Was threshold: 0.1 — never fires on mobile portrait for cgv.html
   and politique-confidentialite.html because those pages have
   data-lang-block elements 2000-3000px tall (verbose FR/EN/MG
   trilingual content) and viewport (~600px) never reaches 10%
   intersection ratio. Now threshold: 0 — fires as soon as any
   pixel enters viewport. mentions-legales.html unaffected because
   its blocks were short enough to satisfy the previous 10%.

Refs: WordPress \xe2\x86\x92 static migration, post-cutover polish.
serge merged commit 5b84e5697e into main 2026-05-07 16:36:29 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: serge/site-mva-global-fret#6
No description provided.
Delete Branch "chore/post-cutover-polish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?